netdev - Re: [patch net-next RFC 02/12] devlink: extend attrs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180323063027.GI2074@nanopsycho.orion>
Date:   Fri, 23 Mar 2018 07:30:27 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, idosch@...lanox.com,
        mlxsw@...lanox.com, andrew@...n.ch,
        vivien.didelot@...oirfairelinux.com, f.fainelli@...il.com,
        michael.chan@...adcom.com, ganeshgr@...lsio.com,
        saeedm@...lanox.com, simon.horman@...ronome.com,
        pieter.jansenvanvuuren@...ronome.com, john.hurley@...ronome.com,
        dirk.vandermerwe@...ronome.com, alexander.h.duyck@...el.com,
        ogerlitz@...lanox.com, dsahern@...il.com, vijaya.guvva@...ium.com,
        satananda.burla@...ium.com, raghu.vatsavayi@...ium.com,
        felix.manlunas@...ium.com, gospo@...adcom.com,
        sathya.perla@...adcom.com, vasundhara-v.volam@...adcom.com,
        tariqt@...lanox.com, eranbe@...lanox.com,
        jeffrey.t.kirsher@...el.com
Subject: Re: [patch net-next RFC 02/12] devlink: extend attrs_set for setting
 port flavours

Fri, Mar 23, 2018 at 04:36:24AM CET, jakub.kicinski@...ronome.com wrote:
>On Thu, 22 Mar 2018 11:55:12 +0100, Jiri Pirko wrote:
>>  enum devlink_attr {
>>  	/* don't change the order or add anything between, this is ABI! */
>>  	DEVLINK_ATTR_UNSPEC,
>> @@ -224,6 +242,7 @@ enum devlink_attr {
>>  	DEVLINK_ATTR_DPIPE_TABLE_RESOURCE_ID,	/* u64 */
>>  	DEVLINK_ATTR_DPIPE_TABLE_RESOURCE_UNITS,/* u64 */
>>  
>> +	DEVLINK_ATTR_PORT_FLAVOUR,		/* u16 */
>>  	DEVLINK_ATTR_PORT_NUMBER,		/* u32 */
>>  	DEVLINK_ATTR_PORT_SPLIT_SUBPORT_NUMBER,	/* u32 */
>
>nit: why is it OK to add the attr in the middle of enum? 

Well, I added the next 2 in previous the patch.