netdev - Re: [patch net-next RFC 00/12] devlink: introduce port flavours and common phys_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5b9222d-1191-467b-2605-d7e1fd5de9d2@gmail.com>
Date:   Sat, 24 Mar 2018 13:05:24 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, idosch@...lanox.com,
        jakub.kicinski@...ronome.com, mlxsw@...lanox.com,
        vivien.didelot@...oirfairelinux.com, michael.chan@...adcom.com,
        ganeshgr@...lsio.com, saeedm@...lanox.com,
        simon.horman@...ronome.com, pieter.jansenvanvuuren@...ronome.com,
        john.hurley@...ronome.com, dirk.vandermerwe@...ronome.com,
        alexander.h.duyck@...el.com, ogerlitz@...lanox.com,
        dsahern@...il.com, vijaya.guvva@...ium.com,
        satananda.burla@...ium.com, raghu.vatsavayi@...ium.com,
        felix.manlunas@...ium.com, gospo@...adcom.com,
        sathya.perla@...adcom.com, vasundhara-v.volam@...adcom.com,
        tariqt@...lanox.com, eranbe@...lanox.com,
        jeffrey.t.kirsher@...el.com
Subject: Re: [patch net-next RFC 00/12] devlink: introduce port flavours and
 common phys_port_name generation



On 24/03/2018 12:00, Andrew Lunn wrote:
>>>>>>>>> root@...-devel-b:~# ./iproute2/devlink/devlink port 
>>>>>>>>> mdio_bus/0.1:00/0: type eth netdev lan0 flavour physical number 0
>>>>>>>>> mdio_bus/0.1:00/1: type eth netdev lan1 flavour physical number 1
>>>>>>>>> mdio_bus/0.1:00/2: type eth netdev lan2 flavour physical number 2
>>>>>>>>> mdio_bus/0.1:00/3: type notset
>>>>>>>>> mdio_bus/0.1:00/4: type notset
>>>>>>>>> mdio_bus/0.1:00/5: type notset flavour dsa number 5
>>>>>>>>> mdio_bus/0.1:00/6: type notset flavour cpu number 6
>>>>>>>>> mdio_bus/0.2:00/0: type eth netdev lan3 flavour physical number 0
>>>>>>>>> mdio_bus/0.2:00/1: type eth netdev lan4 flavour physical number 1
>>>>>>>>> mdio_bus/0.2:00/2: type eth netdev lan5 flavour physical number 2
>>>>>>>>> mdio_bus/0.2:00/3: type notset
>>>>>>>>> mdio_bus/0.2:00/4: type notset
>>>>>>>>> mdio_bus/0.2:00/5: type notset flavour dsa number 5
>>>>>>>>> mdio_bus/0.2:00/6: type notset flavour dsa number 6
>>>>>>>>> mdio_bus/0.4:00/0: type eth netdev lan6 flavour physical number 0
>>>>>>>>> mdio_bus/0.4:00/1: type eth netdev lan7 flavour physical number 1
>>>>>>>>> mdio_bus/0.4:00/2: type eth netdev lan8 flavour physical number 2
>>>>>>>>> mdio_bus/0.4:00/3: type eth netdev optical3 flavour physical
> 
>>> What is an appropriate attribute to use to return the physical port number within a given switch?
>>
>> I don't think there's one out there. I tried to add it in this patchset.
> 
> Florian, do you need it to be unique per switch, or DSA cluster. The
> current solution is clearly not unique across a cluster.

It needs to be unique per switch, we have the switch identifier through
phys_switch_id for higher level "uniqueness".
-- 
Florian