lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 24 Mar 2018 12:52:18 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Saeed Mahameed <saeedm@...lanox.com>, "David S. Miller" <davem@...emloft.net> Cc: netdev@...r.kernel.org, Or Gerlitz <ogerlitz@...lanox.com> Subject: Re: [net 7/8] net/mlx5e: Avoid using the ipv6 stub in the TC offload neigh update path Hello! On 3/24/2018 1:05 AM, Saeed Mahameed wrote: > From: Or Gerlitz <ogerlitz@...lanox.com> > > Currently we use the global ipv6_stub var to access the ipv6 global > nd table. This practice gets us to troubles when the stub is only partially > set e.g when ipv6 is loaded under the disabled policy. In this case, as of commit > 343d60aada5a "ipv6: change ipv6_stub_impl.ipv6_dst_lookup to take net argument" The summary line must be enclosed in (""), not just "". > the stub is not null, but stub->nd_tbl is and we crash. > > As we can access directly the ipv6 nd_tbl, the fix is just avoid the As we can access the ipv6 nd_tbl directly, the fix is just to avoid the > reference through the stub. There is one place in the code were we ^^^^ Where? > issue ipv6 route lookup and keep doing it through the stub, but that > mentioned commit makes sure we get -EAFNOSUPPORT from the stack. > > Fixes: 232c001398ae ('net/mlx5e: Add support to neighbour update flow') ("") here as well. > Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com> > Reviewed-by: Aviv Heller <avivh@...lanox.com> > Signed-off-by: Saeed Mahameed <saeedm@...lanox.com> [...] MBR, Sergei
Powered by blists - more mailing lists