netdev - Re: [v2] vhost: add vsock compat ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180325.165053.1563209987073172496.davem@davemloft.net>
Date:   Sun, 25 Mar 2018 16:50:53 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     stefanha@...il.com
Cc:     sonnyrao@...omium.org, netdev@...r.kernel.org
Subject: Re: [v2] vhost: add vsock compat ioctl

From: Stefan Hajnoczi <stefanha@...il.com>
Date: Thu, 22 Mar 2018 09:25:35 +0000

> On Fri, Mar 16, 2018 at 7:30 PM, David Miller <davem@...emloft.net> wrote:
>> Although the top level ioctls are probably size and layout compatible,
>> I do not think that the deeper ioctls can be called by compat binaries
>> without some translations in order for them to work.
> 
> I audited the vhost ioctl code when reviewing this patch and was
> unable to find anything that would break for a 32-bit userspace
> process.
> 
> drivers/vhost/net.c does the same thing already, which doesn't prove
> it's correct but makes me more confident I didn't miss something while
> auditing the vhost ioctl code.
> 
> Did you have a specific ioctl in mind?

I walked over the vhost ioctl datastructures and they all appear like
they should be compatible.

So I guess it won't be a problem after all.