netdev - Re: [PATCH net-next nfs 1/6] net: Convert rpcsec_gss_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Mar 2018 12:30:28 +0300
From:   Kirill Tkhai <ktkhai@...tuozzo.com>
To:     Anna Schumaker <Anna.Schumaker@...app.com>, davem@...emloft.net,
        trond.myklebust@...marydata.com, bfields@...ldses.org,
        jlayton@...nel.org, dhowells@...hat.com, keescook@...omium.org,
        dwindsor@...il.com, ishkamiel@...il.com, elena.reshetova@...el.com,
        linux-nfs@...r.kernel.org, linux-afs@...ts.infradead.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next nfs 1/6] net: Convert rpcsec_gss_net_ops

On 23.03.2018 21:53, Anna Schumaker wrote:
> 
> 
> On 03/13/2018 06:49 AM, Kirill Tkhai wrote:
>> These pernet_operations initialize and destroy sunrpc_net_id
>> refered per-net items. Only used global list is cache_list,
>> and accesses already serialized.
>>
>> sunrpc_destroy_cache_detail() check for list_empty() without
>> cache_list_lock, but when it's called from unregister_pernet_subsys(),
>> there can't be callers in parallel, so we won't miss list_empty()
>> in this case.
>>
>> Signed-off-by: Kirill Tkhai <ktkhai@...tuozzo.com>
> 
> It might make sense to take these and the other NFS patches through the net tree, since the pernet_operations don't yet have the async field in my tree (and I therefore can't compile once these are applied).
> 
> Acked-by: Anna Schumaker <Anna.Schumaker@...app.com>

Thanks a lot, Anna!

Kirill

>> ---
>>  net/sunrpc/auth_gss/auth_gss.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c
>> index 9463af4b32e8..44f939cb6bc8 100644
>> --- a/net/sunrpc/auth_gss/auth_gss.c
>> +++ b/net/sunrpc/auth_gss/auth_gss.c
>> @@ -2063,6 +2063,7 @@ static __net_exit void rpcsec_gss_exit_net(struct net *net)
>>  static struct pernet_operations rpcsec_gss_net_ops = {
>>  	.init = rpcsec_gss_init_net,
>>  	.exit = rpcsec_gss_exit_net,
>> +	.async = true,
>>  };
>>  
>>  /*
>>