netdev - Re: [PATCH net 1/3] bonding: fix the err path for dev hwaddr sync in bond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e95c72ce-946a-052c-9027-b65dc961027d@cumulusnetworks.com>
Date:   Mon, 26 Mar 2018 17:06:22 +0300
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Xin Long <lucien.xin@...il.com>,
        network dev <netdev@...r.kernel.org>
Cc:     davem@...emloft.net, Jiri Pirko <jiri@...nulli.us>,
        Wang Chen <wangchen@...fujitsu.com>,
        Veaceslav Falico <vfalico@...hat.com>,
        Nikolay Aleksandrov <nikolay@...hat.com>
Subject: Re: [PATCH net 1/3] bonding: fix the err path for dev hwaddr sync in
 bond_enslave

On 25/03/18 20:16, Xin Long wrote:
> vlan_vids_add_by_dev is called right after dev hwaddr sync, so on
> the err path it should unsync dev hwaddr. Otherwise, the slave
> dev's hwaddr will never be unsync when this err happens.
> 
> Fixes: 1ff412ad7714 ("bonding: change the bond's vlan syncing functions with the standard ones")
> Signed-off-by: Xin Long <lucien.xin@...il.com>
> ---
>   drivers/net/bonding/bond_main.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
> 

Seems I've missed the err path back then.
Thanks,
Reviewed-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>