netdev - Re: [PATCH] net: fec: set dma_coherent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <trinity-e93e9d10-7432-4fb0-a576-aeee9207df00-1522157074887@3c-app-gmx-bs61>
Date:   Tue, 27 Mar 2018 15:24:34 +0200
From:   "Lino Sanfilippo" <LinoSanfilippo@....de>
To:     "Greg Ungerer" <gerg@...ux-m68k.org>
Cc:     netdev@...r.kernel.org, linux-m68k@...r.kernel.org,
        "Greg Ungerer" <gerg@...ux-m68k.org>
Subject: Re: [PATCH] net: fec: set dma_coherent_mask

Hi,

>  
> +	dma_set_coherent_mask(&fep->pdev->dev, DMA_BIT_MASK(32));
> +
>  	for (i = 0; i < fep->num_tx_queues; i++) {
>  		txq = kzalloc(sizeof(*txq), GFP_KERNEL);
>  		if (!txq) {

dma_set_coherent_mask() can fail, so the return value should be checked and
a failure be handled accordingly.

Regards,
Lino