netdev - Re: [PATCH v3 iproute2 1/1] tc: fix conversion types when printing actions unsigned values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180327090234.5d457806@xeon-e3>
Date:   Tue, 27 Mar 2018 09:02:34 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Roman Mashak <mrv@...atatu.com>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us
Subject: Re: [PATCH v3 iproute2 1/1] tc: fix conversion types when printing
 actions unsigned values

On Mon, 19 Mar 2018 17:05:41 -0400
Roman Mashak <mrv@...atatu.com> wrote:

> diff --git a/tc/m_gact.c b/tc/m_gact.c
> index 16c4413f4217..52022415db48 100644
> --- a/tc/m_gact.c
> +++ b/tc/m_gact.c
> @@ -194,7 +194,7 @@ print_gact(struct action_util *au, FILE *f, struct rtattr *arg)
>  	print_string(PRINT_ANY, "random_type", "\n\t random type %s",
>  		     prob_n2a(pp->ptype));
>  	print_action_control(f, " ", pp->paction, " ");
> -	print_int(PRINT_ANY, "val", "val %d", pp->pval);
> +	print_int(PRINT_ANY, "val", "val %u", pp->pval);
>  	close_json_object();

This needs to be print_uint in order to work correctly with json output.

Also, please consider doing json on all the match types in a later patch
for net-next.