netdev - Re: [PATCH iproute2] ss: Fix rendering of continuous output (-E, --events)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180327091127.6ac10795@xeon-e3>
Date:   Tue, 27 Mar 2018 09:11:27 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Roman Mashak <mrv@...atatu.com>
Cc:     Stefano Brivio <sbrivio@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] ss: Fix rendering of continuous output (-E,
 --events)

On Fri, 23 Mar 2018 09:30:17 -0400
Roman Mashak <mrv@...atatu.com> wrote:

> Stefano Brivio <sbrivio@...hat.com> writes:
> 
> > Roman Mashak reported that ss currently shows no output when it
> > should continuously report information about terminated sockets
> > (-E, --events switch).
> >
> > This happens because I missed this case in 691bd854bf4a ("ss:
> > Buffer raw fields first, then render them as a table") and the
> > rendering function is simply not called.
> >
> > To fix this, we need to:
> >
> > - call render() every time we need to display new socket events
> >   from generic_show_sock(), which is only used to follow events.
> >   Always call it even if specific socket display functions
> >   return errors to ensure we clean up buffers
> >
> > - get the screen width every time we have new events to display,
> >   thus factor out getting the screen width from main() into a
> >   function we'll call whenever we calculate columns width
> >
> > - reset the current field pointer after rendering, more output
> >   might come after render() is called
> >
> > Reported-by: Roman Mashak <mrv@...atatu.com>
> > Fixes: 691bd854bf4a ("ss: Buffer raw fields first, then render them as a table")
> > Signed-off-by: Stefano Brivio <sbrivio@...hat.com>  
> 
> Thanks Stefano.
> 
> Tested-by: Roman Mashak <mrv@...atatu.com>

Applied