netdev - RE: [EXT] Re: [PATCH net-next] net: mvpp2: Use relaxed I/O in data path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 27 Mar 2018 17:18:16 +0000
From:   Yan Markman <ymarkman@...vell.com>
To:     David Miller <davem@...emloft.net>,
        "maxime.chevallier@...tlin.com" <maxime.chevallier@...tlin.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "antoine.tenart@...tlin.com" <antoine.tenart@...tlin.com>,
        "thomas.petazzoni@...tlin.com" <thomas.petazzoni@...tlin.com>,
        "gregory.clement@...tlin.com" <gregory.clement@...tlin.com>,
        "miquel.raynal@...tlin.com" <miquel.raynal@...tlin.com>,
        Nadav Haklai <nadavh@...vell.com>,
        Stefan Chulski <stefanc@...vell.com>,
        "mw@...ihalf.com" <mw@...ihalf.com>
Subject: RE: [EXT] Re: [PATCH net-next] net: mvpp2: Use relaxed I/O in data
 path

Thanks David
We are aware and it is working properly
Yan Markman


-----Original Message-----
From: David Miller [mailto:davem@...emloft.net] 
Sent: Tuesday, March 27, 2018 8:16 PM
To: maxime.chevallier@...tlin.com
Cc: Yan Markman <ymarkman@...vell.com>; netdev@...r.kernel.org; linux-kernel@...r.kernel.org; antoine.tenart@...tlin.com; thomas.petazzoni@...tlin.com; gregory.clement@...tlin.com; miquel.raynal@...tlin.com; Nadav Haklai <nadavh@...vell.com>; Stefan Chulski <stefanc@...vell.com>; mw@...ihalf.com
Subject: [EXT] Re: [PATCH net-next] net: mvpp2: Use relaxed I/O in data path

External Email

----------------------------------------------------------------------
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
Date: Tue, 27 Mar 2018 16:49:05 +0200

> From: Yan Markman <ymarkman@...vell.com>
> 
> Use relaxed I/O on the hot path. This achieves significant performance 
> improvements. On a 10G link, this makes a basic iperf TCP test go from 
> an average of 4.5 Gbits/sec to about 9.40 Gbits/sec.
> 
> Signed-off-by: Yan Markman <ymarkman@...vell.com>
> [Maxime: Commit message, cosmetic changes]
> Signed-off-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
> ---
> David, this patch should not conflict with other the pending PPv2 
> series I sent earlier ("[PATCH net-next 0/2] net: mvpp2: Remove 
> unnecessary dynamic allocs")

Applied, but it is up to you to make sure the correct barriers are in place such that undesirable memory and IOMEM operation reordering does not occur.

Said another way, you get to keep the pieces if this breaks things :-)