netdev - Re: [PATCH v2 net] strparser: Fix sign of err codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180327.132934.1073739597914168404.davem@davemloft.net>
Date:   Tue, 27 Mar 2018 13:29:34 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     davejwatson@...com
Cc:     tom@...ntonium.net, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net] strparser: Fix sign of err codes

From: Dave Watson <davejwatson@...com>
Date: Tue, 27 Mar 2018 08:23:52 -0700

> strp_parser_err is called with a negative code everywhere, which then
> calls abort_parser with a negative code.  strp_msg_timeout calls
> abort_parser directly with a positive code.  Negate ETIMEDOUT
> to match signed-ness of other calls.
> 
> The default abort_parser callback, strp_abort_strp, sets
> sk->sk_err to err.  Also negate the error here so sk_err always
> holds a positive value, as the rest of the net code expects.  Currently
> a negative sk_err can result in endless loops, or user code that
> thinks it actually sent/received err bytes.
> 
> Found while testing net/tls_sw recv path.
> 
> Fixes: 43a0c6751a322847 ("strparser: Stream parser for messages")
> Signed-off-by: Dave Watson <davejwatson@...com>

Your v1 patch was already applied to my net tree, so you'll have to
send any further changes as a relative patch.