netdev - Re: [PATCH iproute2 1/1] tc: print index, refcnt & bindcnt for nat action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180327150616.681056fc@xeon-e3>
Date:   Tue, 27 Mar 2018 15:06:16 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Roman Mashak <mrv@...atatu.com>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us
Subject: Re: [PATCH iproute2 1/1] tc: print index, refcnt & bindcnt for nat
 action

On Tue, 27 Mar 2018 17:32:31 -0400
Roman Mashak <mrv@...atatu.com> wrote:

> Stephen Hemminger <stephen@...workplumber.org> writes:
> 
> > On Tue, 20 Mar 2018 14:21:47 -0400
> > Roman Mashak <mrv@...atatu.com> wrote:
> >  
> >> Signed-off-by: Roman Mashak <mrv@...atatu.com>
> >> ---
> >>  tc/m_nat.c | 5 +++++
> >>  1 file changed, 5 insertions(+)
> >> 
> >> diff --git a/tc/m_nat.c b/tc/m_nat.c
> >> index 1e4ff51fe75a..f6e373957c1b 100644
> >> --- a/tc/m_nat.c
> >> +++ b/tc/m_nat.c
> >> @@ -169,6 +169,9 @@ print_nat(struct action_util *au, FILE * f, struct rtattr *arg)
> >>  		format_host_r(AF_INET, 4, &sel->new_addr, buf2, sizeof(buf2)));
> >>  	print_action_control(f, " ", sel->action, "");
> >>  
> >> +	fprintf(f, "\n\t index %u ref %d bind %d",
> >> +		sel->index, sel->refcnt, sel->bindcnt);
> >> +
> >>  	if (show_stats) {
> >>  		if (tb[TCA_NAT_TM]) {
> >>  			struct tcf_t *tm = RTA_DATA(tb[TCA_NAT_TM]);
> >> @@ -177,6 +180,8 @@ print_nat(struct action_util *au, FILE * f, struct rtattr *arg)
> >>  		}
> >>  	}
> >>  
> >> +	fprintf(f, "\n");
> >> +
> >>  	return 0;
> >>  }  
> >
> > Rather than printing newline all the time, you need to use _SL_ to keep the optional
> > oneline output format.
> >
> > I.e
> > 	fprintf(f, "%s\t index %u ref %d bind %d",
> > 		_SL_, sel->index, sel->refcnt, sel->bindcnt);  
> 
> tc currently doesn't support oneline mode, so I'll have to add it first,
> then update all actions to use the oneliner.

Ok, never mind then. Let's just get to it as part of the JSON work.
I spent too much staring at ip ...