netdev - Re: [PATCH V4 net-next 06/14] net/tls: Add generic NIC offload infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALzJLG-E77nFeQJj-CLf-UQAEx3S-=s2-Lws5bBQZN=3GM3zcQ@mail.gmail.com>
Date:   Tue, 27 Mar 2018 16:02:15 -0700
From:   Saeed Mahameed <saeedm@....mellanox.co.il>
To:     Dave Watson <davejwatson@...com>
Cc:     Saeed Mahameed <saeedm@...lanox.com>,
        "David S. Miller" <davem@...emloft.net>,
        Linux Netdev List <netdev@...r.kernel.org>,
        Boris Pismenny <borisp@...lanox.com>,
        Ilya Lesokhin <ilyal@...lanox.com>,
        Aviad Yehezkel <aviadye@...lanox.com>
Subject: Re: [PATCH V4 net-next 06/14] net/tls: Add generic NIC offload infrastructure

On Tue, Mar 27, 2018 at 3:26 PM, Dave Watson <davejwatson@...com> wrote:
> Thanks for doing the merge, it looks good to me.  One issue below,
> otherwise all my SW tests still pass.
>
> On 03/27/18 02:51 PM, Saeed Mahameed wrote:
>> -     if (ctx->conf == TLS_SW_TX ||
>> -         ctx->conf == TLS_SW_RX ||
>> -         ctx->conf == TLS_SW_RXTX) {
>> -             tls_sw_free_resources(sk);
>> +     if (ctx->rx_conf == TLS_SW) {
>> +             kfree(ctx->rx.rec_seq);
>> +             kfree(ctx->rx.iv);
>> +             tls_sw_free_resources_rx(sk);
>>       }
>>
>> +     if (ctx->tx_conf != TLS_HW)
>> +             kfree(ctx);
>
> Looks like this needs to be hidden behind CONFIG_TLS_DEVICE, otherwise
> it doesn't compile if false because TLS_HW is not defined
>
Correct, Will fix.

Thanks Dave !