netdev - Re: [PATCH net-next nfs 1/6] net: Convert rpcsec_gss_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4f1d883b-8c5c-41b3-e287-37cd0061c11c@virtuozzo.com>
Date:   Tue, 27 Mar 2018 11:52:09 +0300
From:   Kirill Tkhai <ktkhai@...tuozzo.com>
To:     "J. Bruce Fields" <bfields@...ldses.org>,
        Anna Schumaker <Anna.Schumaker@...app.com>
Cc:     davem@...emloft.net, trond.myklebust@...marydata.com,
        jlayton@...nel.org, dhowells@...hat.com, keescook@...omium.org,
        dwindsor@...il.com, ishkamiel@...il.com, elena.reshetova@...el.com,
        linux-nfs@...r.kernel.org, linux-afs@...ts.infradead.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next nfs 1/6] net: Convert rpcsec_gss_net_ops

On 26.03.2018 21:36, J. Bruce Fields wrote:
> On Fri, Mar 23, 2018 at 02:53:34PM -0400, Anna Schumaker wrote:
>>
>>
>> On 03/13/2018 06:49 AM, Kirill Tkhai wrote:
>>> These pernet_operations initialize and destroy sunrpc_net_id refered
>>> per-net items. Only used global list is cache_list, and accesses
>>> already serialized.
>>>
>>> sunrpc_destroy_cache_detail() check for list_empty() without
>>> cache_list_lock, but when it's called from
>>> unregister_pernet_subsys(), there can't be callers in parallel, so
>>> we won't miss list_empty() in this case.
>>>
>>> Signed-off-by: Kirill Tkhai <ktkhai@...tuozzo.com>
>>
>> It might make sense to take these and the other NFS patches through
>> the net tree, since the pernet_operations don't yet have the async
>> field in my tree (and I therefore can't compile once these are
>> applied).
> 
> Ditto for the nfsd patch, so, for what it's worth:
> 
> 	Acked-by: J. Bruce Fields <bfields@...hat.com>
> 
> for that patch.--b.

Thanks, Bruce.

Kirill