netdev - ip6_forward / NF_HOOK and counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL6e_pesVesD+SEC5FQXhHLLq-oPJZNrwiMgjX=ynm0GX4jEZw@mail.gmail.com>
Date:   Mon, 26 Mar 2018 21:35:07 -0400
From:   Jeff Barnhill <0xeffeff@...il.com>
To:     netdev@...r.kernel.org
Subject: ip6_forward / NF_HOOK and counters

At the end of ip6_forward(), is there a good reason why
IPSTATS_MIB_OUTFORWDATAGRAMS and IPSTATS_MIB_OUTOCTETS are incremented
before the NF_HOOK?  If the hook steals or drops the packet, this
counts still go up, which seems incorrect.

v4/ip_forward() increments these counters in ip_forward_finish().  It
seems that v6 should do it in ip6_forward_finish() ?? Thoughts?

Jeff