netdev - Re: [PATCH] [net-next] sctp: fix unused lable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180328151925.GA21759@neilslaptop.think-freely.org>
Date:   Wed, 28 Mar 2018 11:19:25 -0400
From:   Neil Horman <nhorman@...driver.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Vlad Yasevich <vyasevich@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Al Viro <viro@...IV.linux.org.uk>, linux-sctp@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [net-next] sctp: fix unused lable warning

On Wed, Mar 28, 2018 at 04:14:56PM +0200, Arnd Bergmann wrote:
> The proc file cleanup left a label possibly unused:
> 
> net/sctp/protocol.c: In function 'sctp_defaults_init':
> net/sctp/protocol.c:1304:1: error: label 'err_init_proc' defined but not used [-Werror=unused-label]
> 
> This adds an #ifdef around it to match the respective 'goto'.
> 
> Fixes: d47d08c8ca05 ("sctp: use proc_remove_subtree()")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  net/sctp/protocol.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c
> index c1c64b78c39d..d685f8456762 100644
> --- a/net/sctp/protocol.c
> +++ b/net/sctp/protocol.c
> @@ -1301,8 +1301,10 @@ static int __net_init sctp_defaults_init(struct net *net)
>  
>  	return 0;
>  
> +#ifdef CONFIG_PROC_FS
>  err_init_proc:
>  	cleanup_sctp_mibs(net);
> +#endif
>  err_init_mibs:
>  	sctp_sysctl_net_unregister(net);
>  err_sysctl_register:
> -- 
> 2.9.0
> 
> 
Acked-by: Neil Horman <nhorman@...driver.com>