netdev - Re: [PATCH v8 bpf-next 6/9] bpf: introduce BPF_RAW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2000920858.249.1522266527563.JavaMail.zimbra@efficios.com>
Date:   Wed, 28 Mar 2018 15:48:47 -0400 (EDT)
From:   Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To:     rostedt <rostedt@...dmis.org>
Cc:     Alexei Starovoitov <ast@...com>,
        Alexei Starovoitov <ast@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Daniel Borkmann <daniel@...earbox.net>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>,
        netdev <netdev@...r.kernel.org>,
        kernel-team <kernel-team@...com>,
        linux-api <linux-api@...r.kernel.org>
Subject: Re: [PATCH v8 bpf-next 6/9] bpf: introduce BPF_RAW_TRACEPOINT

----- On Mar 28, 2018, at 3:40 PM, rostedt rostedt@...dmis.org wrote:

> On Wed, 28 Mar 2018 12:38:48 -0700
> Alexei Starovoitov <ast@...com> wrote:
> 
>> On 3/28/18 12:34 PM, Steven Rostedt wrote:
>> > On Wed, 28 Mar 2018 12:05:37 -0700
>> > Alexei Starovoitov <ast@...nel.org> wrote:
>> >  
>> >> +++ b/include/linux/tracepoint-defs.h
>> >> @@ -35,4 +35,10 @@ struct tracepoint {
>> >>  	struct tracepoint_func __rcu *funcs;
>> >>  };
>> >>
>> >> +struct bpf_raw_event_map {
>> >> +	struct tracepoint	*tp;
>> >> +	void			*bpf_func;
>> >> +	u32			num_args;
>> >> +} __aligned(32);
>> >> +
>> >
>> > If you prefer v7, I'm fine with that. For cache issues, I can pull out
>> > the funcs from the tracepoint structure like I posted.
>> 
>> I very much prefer to land this v8 as-is and optimize later.
>> 
>> I still have bpfilter/microkernel patches to finish which were
>> practically ready two weeks ago and got delayed but this set.
> 
> Then by all means, you have my Ack. We can optimize later.
> 
> For the whole series... (v7 or v8)
> 
> Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

I'm fine with either v7 or v8 as well.

Thanks,

Mathieu

> 
> Thanks!
> 
> -- Steve

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com