netdev - RE: [PATCH] staging: fsl-dpaa2/ethsw: Fix TCI values overwrite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM3PR04MB0743BA40A26E4BA605C974D8E6A30@AM3PR04MB0743.eurprd04.prod.outlook.com>
Date:   Wed, 28 Mar 2018 06:45:31 +0000
From:   Razvan Stefanescu <razvan.stefanescu@....com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Alexandru Marginean <alexandru.marginean@....com>,
        Ruxandra Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Laurentiu Tudor <laurentiu.tudor@....com>
Subject: RE: [PATCH] staging: fsl-dpaa2/ethsw: Fix TCI values overwrite



> -----Original Message-----
> From: linux-kernel-owner@...r.kernel.org [mailto:linux-kernel-
> owner@...r.kernel.org] On Behalf Of Andrew Lunn
> Sent: Tuesday, March 27, 2018 4:38 PM
> To: Razvan Stefanescu <razvan.stefanescu@....com>
> Cc: gregkh@...uxfoundation.org; devel@...verdev.osuosl.org; linux-
> kernel@...r.kernel.org; netdev@...r.kernel.org; Alexandru Marginean
> <alexandru.marginean@....com>; Ruxandra Ioana Ciocoi Radulescu
> <ruxandra.radulescu@....com>; Ioana Ciornei <ioana.ciornei@....com>;
> Laurentiu Tudor <laurentiu.tudor@....com>; stuyoder@...il.com
> Subject: Re: [PATCH] staging: fsl-dpaa2/ethsw: Fix TCI values overwrite
> 
> On Tue, Mar 27, 2018 at 08:10:50AM -0500, Razvan Stefanescu wrote:
> > Previous implementation overwrites PCP value, assuming the default value
> is
> > 0, instead of 7.
> >
> > Avoid this by modifying helper function ethsw_port_set_tci() to
> > ethsw_port_set_pvid() and make it update only the vlan_id of the tci_cfg
> > struct.
> 
> Hi Razvan
> 
> It is a good idea to explain acronyms, especially for staging, since
> there are patches for all sorts of devices, can you cannot expect
> everybody to know network specific acronyms.
> 
> By PCP you mean Priority Code Point. TCI i have no idea about.
> 
> Looking at the code, i think you are changing the flow to become
> read/modify/write, instead of just write, which is overwriting the
> previously configured Priority Code Point?
> 
> Please try to add more details to your change logs, to help us
> understand the change.
> 

Thank you Andrew.  I'll address this in v2.

Best regards,
Razvan Stefanescu