netdev - Re: [PATCH net-next] net: hns3: remove unnecessary pci_set_drvdata() and devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180329.143520.180872666601831050.davem@davemloft.net>
Date:   Thu, 29 Mar 2018 14:35:20 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     weiyongjun1@...wei.com
Cc:     yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: hns3: remove unnecessary
 pci_set_drvdata() and devm_kfree()

From: Wei Yongjun <weiyongjun1@...wei.com>
Date: Wed, 28 Mar 2018 12:51:01 +0000

> The devm_kfree function allocates memory that is released when a

devm_kfree doesn't allocate memory, it frees it.

Your commit log message is confusing at best.  I know what you're
trying to say, but a lot of the logic is reversed or hard to
understand.

Thank you.