netdev - Re: [PATCH net-next] net: systemport: Add support for BQL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180329.155651.639613872542750958.davem@davemloft.net>
Date:   Thu, 29 Mar 2018 15:56:51 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, opendmb@...il.com
Subject: Re: [PATCH net-next] net: systemport: Add support for BQL

From: Florian Fainelli <f.fainelli@...il.com>
Date: Thu, 29 Mar 2018 12:30:08 -0700

> On 03/29/2018 12:27 PM, Florian Fainelli wrote:
>> We had all the accounting done already, but we did not plumb BQL. In
>> order to avoid fetching twice the netdev_queue pointer in the TX
>> reclamation path, move the queue waking into __bcm_sysport_tx_reclaim()
>> so we can update BQL and wake the TX queue there in one go.
>> 
>> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> 
> David, please disregard this patch, I found a bunch of issues, and it
> won't apply with the coalescing patch series.

Sure, no problem.