netdev - Re: [PATCH net-next 6/6] netdevsim: Add simple FIB resource controller via devlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d0f6ef6-111b-1cb9-1cd6-2ccdef5d5020@cumulusnetworks.com>
Date:   Thu, 29 Mar 2018 14:01:06 -0600
From:   David Ahern <dsa@...ulusnetworks.com>
To:     David Miller <davem@...emloft.net>, jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, roopa@...ulusnetworks.com,
        shm@...ulusnetworks.com, jiri@...lanox.com, idosch@...lanox.com,
        andy.roulin@...il.com
Subject: Re: [PATCH net-next 6/6] netdevsim: Add simple FIB resource
 controller via devlink

On 3/29/18 12:11 PM, David Miller wrote:
> From: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Date: Tue, 27 Mar 2018 18:34:50 -0700
> 
>> On Tue, 27 Mar 2018 18:22:00 -0700, David Ahern wrote:
>>> +void nsim_devlink_setup(struct netdevsim *ns)
>>> +{
>  ...
>> nit: DaveM expressed preference to not have silent failures in a
>>      discussion about DebugFS, not sure it applies here, but why not
>>      handle errors?
> 
> Yes it is a concern.
> 
> David please address this as a follow-up.

Will do.