netdev - Re: [PATCH net] vhost: validate log when IOTLB is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180329.162312.1243047104828828329.davem@davemloft.net>
Date:   Thu, 29 Mar 2018 16:23:12 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     mst@...hat.com
Cc:     jasowang@...hat.com, kvm@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] vhost: validate log when IOTLB is enabled

From: "Michael S. Tsirkin" <mst@...hat.com>
Date: Thu, 29 Mar 2018 15:48:22 +0300

> On Thu, Mar 29, 2018 at 04:00:04PM +0800, Jason Wang wrote:
>> Vq log_base is the userspace address of bitmap which has nothing to do
>> with IOTLB. So it needs to be validated unconditionally otherwise we
>> may try use 0 as log_base which may lead to pin pages that will lead
>> unexpected result (e.g trigger BUG_ON() in set_bit_to_user()).
>> 
>> Fixes: 6b1e6cc7855b0 ("vhost: new device IOTLB API")
>> Reported-by: syzbot+6304bf97ef436580fede@...kaller.appspotmail.com
>> Signed-off-by: Jason Wang <jasowang@...hat.com>
> 
> Acked-by: Michael S. Tsirkin <mst@...hat.com>
> 
> stable material I guess.

Applied and queued up for -stable.