netdev - Re: [PATCH] ISDN: eicon: message: remove redundant check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <17ba7cdf-7e53-36f0-5ef0-f81aa3c560ca@embeddedor.com>
Date:   Fri, 30 Mar 2018 11:32:31 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Joe Perches <joe@...ches.com>, Armin Schindler <mac@...ware.de>,
        Karsten Keil <isdn@...ux-pingi.de>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ISDN: eicon: message: remove redundant check



On 03/30/2018 11:19 AM, Joe Perches wrote:
> On Fri, 2018-03-30 at 10:46 -0500, Gustavo A. R. Silva wrote:
>> Check on plci->internal_command is unnecessary.
> 
> Probably all of these are unnecessary too:
> 
> $ for length in {7..2} ; do \
>      grep-2.5.4 -rP --include=*.[ch] -n "^\t{$length,$length}break;\n\t{$(($length-1)),$(($length-1))}break;" * ; \
>    done
> drivers/staging/wilc1000/wilc_wlan.c:691:				break;
> 			break;
> drivers/media/dvb-frontends/drxd_hard.c:2261:				break;
> 			break;
> drivers/media/dvb-frontends/drxd_hard.c:2266:				break;
> 			break;
> drivers/media/usb/gspca/sn9c20x.c:1860:			break;
> 		break;
> drivers/isdn/i4l/isdn_common.c:624:			break;
> 		break;
> drivers/isdn/i4l/isdn_common.c:642:			break;
> 		break;
> drivers/isdn/i4l/isdn_common.c:654:			break;
> 		break;
> drivers/isdn/hardware/eicon/message.c:13890:			break;
> 		break;
> sound/usb/mixer_quirks.c:1832:			break;
> 		break;
> 

Oh, cool.

I'll take a look at them.

Thanks, Joe.
--
Gustavo