netdev - Re: [PATCH net] net/dim: Fix int overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180330.125635.2202630540480329718.davem@davemloft.net>
Date:   Fri, 30 Mar 2018 12:56:35 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     talgi@...lanox.com
Cc:     netdev@...r.kernel.org, tariqt@...lanox.com,
        andrew.gospodarek@...adcom.com, saeedm@...lanox.com
Subject: Re: [PATCH net] net/dim: Fix int overflow

From: Tal Gilboa <talgi@...lanox.com>
Date: Thu, 29 Mar 2018 13:53:52 +0300

> When calculating difference between samples, the values
> are multiplied by 100. Large values may cause int overflow
> when multiplied (usually on first iteration).
> Fixed by forcing 100 to be of type unsigned long.
> 
> Fixes: 4c4dbb4a7363 ("net/mlx5e: Move dynamic interrupt coalescing code to include/linux")
> Signed-off-by: Tal Gilboa <talgi@...lanox.com>

Applied, thank you.