netdev - Re: [PATCH net] vrf: Fix use after free and double free in vrf_finish

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 30 Mar 2018 14:21:10 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...il.com
Cc:     netdev@...r.kernel.org, mfadon@...dat.com
Subject: Re: [PATCH net] vrf: Fix use after free and double free in
 vrf_finish_output

From: David Ahern <dsahern@...il.com>
Date: Thu, 29 Mar 2018 12:49:52 -0700

> Miguel reported an skb use after free / double free in vrf_finish_output
> when neigh_output returns an error. The vrf driver should return after
> the call to neigh_output as it takes over the skb on error path as well.
> 
> Patch is a simplified version of Miguel's patch which was written for 4.9,
> and updated to top of tree.
> 
> Fixes: 8f58336d3f78a ("net: Add ethernet header for pass through VRF device")
> Signed-off-by: Miguel Fadon Perlines <mfadon@...dat.com>
> Signed-off-by: David Ahern <dsahern@...il.com>

Applied and queued up for -stable, thanks David.