netdev - [RFC PATCH] xdp: mem_id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180330190736.GA69677@lkp-sb04>
Date:   Sat, 31 Mar 2018 03:07:36 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        BjörnTöpel <bjorn.topel@...el.com>,
        magnus.karlsson@...el.com, eugenia@...lanox.com,
        Jason Wang <jasowang@...hat.com>,
        John Fastabend <john.fastabend@...il.com>,
        Eran Ben Elisha <eranbe@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>, galp@...lanox.com,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Daniel Borkmann <borkmann@...earbox.net>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Tariq Toukan <tariqt@...lanox.com>
Subject: [RFC PATCH] xdp: mem_id_pool can be static


Fixes: a5c71e7a9fe0 ("xdp: rhashtable with allocator ID to pointer mapping")
Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---
 xdp.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/net/core/xdp.c b/net/core/xdp.c
index e7f11f0..6697900 100644
--- a/net/core/xdp.c
+++ b/net/core/xdp.c
@@ -16,7 +16,7 @@
 #define REG_STATE_UNREGISTERED	0x2
 #define REG_STATE_UNUSED	0x3
 
-DEFINE_IDA(mem_id_pool);
+static DEFINE_IDA(mem_id_pool);
 static DEFINE_MUTEX(mem_id_lock);
 #define MEM_ID_MAX 0xFFFE
 #define MEM_ID_MIN 1
@@ -65,7 +65,7 @@ static const struct rhashtable_params mem_id_rht_params = {
 	.obj_cmpfn = xdp_mem_id_cmp,
 };
 
-void __xdp_mem_allocator_rcu_free(struct rcu_head *rcu)
+static void __xdp_mem_allocator_rcu_free(struct rcu_head *rcu)
 {
 	struct xdp_mem_allocator *xa;
 
@@ -84,7 +84,7 @@ void __xdp_mem_allocator_rcu_free(struct rcu_head *rcu)
 	kfree(xa);
 }
 
-void __xdp_rxq_info_unreg_mem_model(struct xdp_rxq_info *xdp_rxq)
+static void __xdp_rxq_info_unreg_mem_model(struct xdp_rxq_info *xdp_rxq)
 {
 	struct xdp_mem_allocator *xa;
 	int id = xdp_rxq->mem.id;
@@ -174,7 +174,7 @@ bool xdp_rxq_info_is_reg(struct xdp_rxq_info *xdp_rxq)
 }
 EXPORT_SYMBOL_GPL(xdp_rxq_info_is_reg);
 
-int __mem_id_init_hash_table(void)
+static int __mem_id_init_hash_table(void)
 {
 	struct rhashtable *rht;
 	int ret;