netdev - Re: [net-next V7 PATCH 12/16] page_pool: refurbish version of page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201803310337.jMYE6K1P%fengguang.wu@intel.com>
Date:   Sat, 31 Mar 2018 03:58:51 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        BjörnTöpel <bjorn.topel@...el.com>,
        magnus.karlsson@...el.com, eugenia@...lanox.com,
        Jason Wang <jasowang@...hat.com>,
        John Fastabend <john.fastabend@...il.com>,
        Eran Ben Elisha <eranbe@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>, galp@...lanox.com,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Daniel Borkmann <borkmann@...earbox.net>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Tariq Toukan <tariqt@...lanox.com>
Subject: Re: [net-next V7 PATCH 12/16] page_pool: refurbish version of
 page_pool code

Hi Jesper,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Jesper-Dangaard-Brouer/XDP-redirect-memory-return-API/20180330-203122
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> net/core/page_pool.c:17:5: sparse: symbol 'page_pool_init' was not declared. Should it be static?
>> net/core/page_pool.c:198:6: sparse: symbol '__page_pool_recycle_into_ring' was not declared. Should it be static?
>> net/core/page_pool.c:267:6: sparse: symbol '__page_pool_empty_ring' was not declared. Should it be static?
>> net/core/page_pool.c:282:6: sparse: symbol '__page_pool_destroy_rcu' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation