netdev - Re: [PATCH net-next 2/3] netfilter: Rework xt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180330094745.stx5hq5qx2qi3l7u@salvia>
Date:   Fri, 30 Mar 2018 11:47:45 +0200
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Kirill Tkhai <ktkhai@...tuozzo.com>
Cc:     davem@...emloft.net, steffen.klassert@...unet.com,
        herbert@...dor.apana.org.au, kadlec@...ckhole.kfki.hu,
        fw@...len.de, daniel@...earbox.net, jakub.kicinski@...ronome.com,
        ast@...nel.org, brouer@...hat.com, linux@...musvillemoes.dk,
        john.fastabend@...il.com, dsahern@...il.com,
        netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
        coreteam@...filter.org
Subject: Re: [PATCH net-next 2/3] netfilter: Rework xt_TEE netdevice notifier

On Thu, Mar 29, 2018 at 05:03:35PM +0300, Kirill Tkhai wrote:
> Register netdevice notifier for every iptable entry
> is not good, since this breaks modularity, and
> the hidden synchronization is based on rtnl_lock().
> 
> This patch reworks the synchronization via new lock,
> while the rest of logic remains as it was before.
> This is required for the next patch.
> 
> Tested via:
> 
> while :; do
> 	unshare -n iptables -t mangle -A OUTPUT -j TEE --gateway 1.1.1.2 --oif lo;
> done
> 
> Signed-off-by: Kirill Tkhai <ktkhai@...tuozzo.com>

Acked-by: Pablo Neira Ayuso <pablo@...filter.org>