netdev - Re: [PATCH] netfilter: ipset: Use is_zero_ether

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180330095406.chw56e7rizhmcfuo@salvia>
Date:   Fri, 30 Mar 2018 11:54:06 +0200
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Joe Perches <joe@...ches.com>
Cc:     linux-kernel@...r.kernel.org,
        Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        Florian Westphal <fw@...len.de>,
        "David S. Miller" <davem@...emloft.net>,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] netfilter: ipset: Use is_zero_ether_addr instead of
 static and memcmp

On Tue, Mar 20, 2018 at 10:35:47AM -0700, Joe Perches wrote:
> To make the test a bit clearer and to reduce object size a little.
> 
> Miscellanea:
> 
> o remove now unnecessary static const array
> 
> $ size ip_set_hash_mac.o*
>    text	   data	    bss	    dec	    hex	filename
>   22822	   4619	     64	  27505	   6b71	ip_set_hash_mac.o.allyesconfig.new
>   22932	   4683	     64	  27679	   6c1f	ip_set_hash_mac.o.allyesconfig.old
>   10443	   1040	      0	  11483	   2cdb	ip_set_hash_mac.o.defconfig.new
>   10507	   1040	      0	  11547	   2d1b	ip_set_hash_mac.o.defconfig.old

Applied, thanks Joe.