netdev - Re: [RFC PATCH] inet: frags: lowpan_rhash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d9ea1014-76f9-6a06-450d-c6cb008d8529@gmail.com>
Date:   Sat, 31 Mar 2018 06:46:39 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     kbuild test robot <lkp@...el.com>,
        Eric Dumazet <edumazet@...gle.com>
Cc:     kbuild-all@...org, "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>, Florian Westphal <fw@...len.de>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Thomas Graf <tgraf@...g.ch>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Alexander Aring <alex.aring@...il.com>,
        Stefan Schmidt <stefan@....samsung.com>,
        Kirill Tkhai <ktkhai@...tuozzo.com>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [RFC PATCH] inet: frags: lowpan_rhash_params can be static



On 03/31/2018 12:47 AM, kbuild test robot wrote:
> 
> Fixes: b051dbce5e50 ("inet: frags: use rhashtables for reassembly units")
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---
>  reassembly.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ieee802154/6lowpan/reassembly.c b/net/ieee802154/6lowpan/reassembly.c
> index dd743c2..0fa0121 100644
> --- a/net/ieee802154/6lowpan/reassembly.c
> +++ b/net/ieee802154/6lowpan/reassembly.c
> @@ -597,7 +597,7 @@ static int lowpan_obj_cmpfn(struct rhashtable_compare_arg *arg, const void *ptr)
>  	return !!memcmp(&fq->key, key, sizeof(*key));
>  }
>  
> -const struct rhashtable_params lowpan_rhash_params = {
> +static const struct rhashtable_params lowpan_rhash_params = {
>  	.head_offset		= offsetof(struct inet_frag_queue, node),
>  	.hashfn			= lowpan_key_hashfn,
>  	.obj_hashfn		= lowpan_obj_hashfn,
> 

Thanks for the report/patch. I will squash this in the V4 submission.