netdev - Re: [PATCH RESEND net-next 0/2] net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180331.222514.944117833941358821.davem@davemloft.net>
Date:   Sat, 31 Mar 2018 22:25:14 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     ktkhai@...tuozzo.com
Cc:     zhangshengju@...s.chinamobile.com, jakub.kicinski@...ronome.com,
        dsahern@...il.com, mschiffer@...verse-factory.net,
        daniel@...earbox.net, netdev@...r.kernel.org
Subject: Re: [PATCH RESEND net-next 0/2] net_rwsem fixes

From: Kirill Tkhai <ktkhai@...tuozzo.com>
Date: Fri, 30 Mar 2018 19:38:16 +0300

> there is wext_netdev_notifier_call()->wireless_nlevent_flush()
> netdevice notifier, which takes net_rwsem, so we can't take
> net_rwsem in {,un}register_netdevice_notifier().
> 
> Since {,un}register_netdevice_notifier() is executed under
> pernet_ops_rwsem, net_namespace_list can't change, while we
> holding it, so there is no need net_rwsem in these functions [1/2].
> 
> The same is in [2/2]. We make callers of __rtnl_link_unregister()
> take pernet_ops_rwsem, and close the race with setup_net()
> and cleanup_net(), so __rtnl_link_unregister() does not need it.
> This also fixes the problem of that __rtnl_link_unregister() does
> not see initializing and exiting nets.

Series applied.