netdev - Re: [PATCH v2 net-next 10/10] mlxsw: spectrum: Don't use resource ID of 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <092640cf-c42b-5e2a-60df-7069361d4405@gmail.com>
Date:   Sun, 1 Apr 2018 09:26:18 -0600
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...lanox.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, jiri@...lanox.com, petrm@...lanox.com,
        mlxsw@...lanox.com
Subject: Re: [PATCH v2 net-next 10/10] mlxsw: spectrum: Don't use resource ID
 of 0

On 4/1/18 8:34 AM, Ido Schimmel wrote:
> From: Petr Machata <petrm@...lanox.com>
> 
> In commit 145307460ba9 ("devlink: Remove top_hierarchy arg to
> devlink_resource_register"), the "top_hierarchy" parameter to
> devlink_resource_register() was removed in favor of using the parameter
> "parent_resource_id" exclusively to determine who the parent is. The
> root node's resource ID for this purpose is
> DEVLINK_RESOURCE_ID_PARENT_TOP with the value 0. It is therefore
> problematic that the resource MLXSW_SP_RESOURCE_KVD has also ID of 0.
> 
> Fix this by numbering driver-specific resources from 1.
> 
> Fixes: 145307460ba9 ("devlink: Remove top_hierarchy arg to devlink_resource_register")
> Signed-off-by: Petr Machata <petrm@...lanox.com>
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> ---
>  drivers/net/ethernet/mellanox/mlxsw/spectrum.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

not sure how I missed this; I booted the switch with the above patch.
Thanks for fixing.