netdev - Re: [BUG/Q] can_pernet_exit() leaves devices on dead net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <377fbd8a-cd7e-2650-8efd-907cea0a0aee@hartkopp.net>
Date:   Mon, 2 Apr 2018 17:28:15 +0200
From:   Oliver Hartkopp <socketcan@...tkopp.net>
To:     Kirill Tkhai <ktkhai@...tuozzo.com>, mkl@...gutronix.de
Cc:     linux-can@...r.kernel.org, netdev@...r.kernel.org, dev@...herer.org
Subject: Re: [BUG/Q] can_pernet_exit() leaves devices on dead net

Hi Kirill, Marc,

I checked the code once more and added some debug output to the other 
parts in CAN notifier code.

In fact the code pointed to by both of you seems to be obsolete as I 
only wanted to be 'really sure' that no leftovers of the CAN filters at 
module unloading.

> Yes, this one looks good:
> https://marc.info/?l=linux-can&m=150169589119335&w=2
> 
> Regards,
> Kirill
> 

I was obviously too cautious ;-)

All tests I made resulted in the function iterating through all the CAN 
netdevices doing exactly nothing.

I'm fine with removing that stuff - but I'm not sure whether it's worth 
to push that patch to stable 4.12+ or even before 4.12 (without 
namespace support - and removing rcu_barrier() too).

Any opinions?

Best regards,
Oliver