netdev - Re: [PATCH net-next V2 4/4] net/mlx5e: Enable adaptive-TX moderation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180402.102636.256697366703977259.davem@davemloft.net>
Date:   Mon, 02 Apr 2018 10:26:36 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     talgi@...lanox.com
Cc:     netdev@...r.kernel.org, tariqt@...lanox.com, saeedm@...lanox.com,
        f.fainelli@...il.com
Subject: Re: [PATCH net-next V2 4/4] net/mlx5e: Enable adaptive-TX
 moderation

From: Tal Gilboa <talgi@...lanox.com>
Date: Mon,  2 Apr 2018 16:59:34 +0300

> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_dim.c b/drivers/net/ethernet/mellanox/mlx5/core/en_dim.c
> index 1b286e1..9cec351 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_dim.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_dim.c
> @@ -33,16 +33,30 @@
>  #include <linux/net_dim.h>
>  #include "en.h"
>  
> +static inline void
> +mlx5e_complete_dim_work(struct net_dim *dim, struct net_dim_cq_moder moder,
> +			struct mlx5_core_dev *mdev, struct mlx5_core_cq *mcq)

Do not use inline in foo.c files, let the compiler decide.

> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c
> index f292bb3..ff1d5fe 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c
> @@ -44,6 +44,30 @@ static inline bool mlx5e_channel_no_affinity_change(struct mlx5e_channel *c)
>  	return cpumask_test_cpu(current_cpu, aff);
>  }
>  
> +static inline void mlx5e_handle_tx_dim(struct mlx5e_txqsq *sq)
> +{
> +	struct net_dim_sample dim_sample;

Likewise.

> +static inline void mlx5e_handle_rx_dim(struct mlx5e_rq *rq)
> +{

Likewise.