netdev - RE: [PATCH iproute2 rdma: Ignore unknown netlink attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <016b01d3cb50$3adc88b0$b0959a10$@opengridcomputing.com>
Date:   Tue, 3 Apr 2018 08:32:36 -0500
From:   "Steve Wise" <swise@...ngridcomputing.com>
To:     "'Leon Romanovsky'" <leon@...nel.org>,
        "'Stephen Hemminger'" <stephen@...workplumber.org>
Cc:     "'Leon Romanovsky'" <leonro@...lanox.com>,
        "'netdev'" <netdev@...r.kernel.org>,
        "'RDMA mailing list'" <linux-rdma@...r.kernel.org>,
        "'David Ahern'" <dsahern@...il.com>
Subject: RE: [PATCH iproute2 rdma: Ignore unknown netlink attributes



> -----Original Message-----
> From: Leon Romanovsky <leon@...nel.org>
> Sent: Tuesday, April 3, 2018 2:29 AM
> To: Stephen Hemminger <stephen@...workplumber.org>
> Cc: Leon Romanovsky <leonro@...lanox.com>; netdev
> <netdev@...r.kernel.org>; RDMA mailing list <linux-
> rdma@...r.kernel.org>; David Ahern <dsahern@...il.com>; Steve Wise
> <swise@...ngridcomputing.com>
> Subject: [PATCH iproute2 rdma: Ignore unknown netlink attributes
> 
> From: Leon Romanovsky <leonro@...lanox.com>
> 
> The check if netlink attributes supplied more than maximum supported
> is to strict and may lead to backward compatibility issues with old
> application with a newer kernel that supports new attribute.
> 
> CC: Steve Wise <swise@...ngridcomputing.com>
> Fixes: 74bd75c2b68d ("rdma: Add basic infrastructure for RDMA tool")
> Signed-off-by: Leon Romanovsky <leonro@...lanox.com>
> ---
>  rdma/utils.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/rdma/utils.c b/rdma/utils.c
> index a2e08e91..5c1e736a 100644
> --- a/rdma/utils.c
> +++ b/rdma/utils.c
> @@ -399,7 +399,8 @@ int rd_attr_cb(const struct nlattr *attr, void *data)
>  	int type;
> 
>  	if (mnl_attr_type_valid(attr, RDMA_NLDEV_ATTR_MAX) < 0)
> -		return MNL_CB_ERROR;
> +		/* We received uknown attribute */
> +		return MNL_CB_OK;
> 
>  	type = mnl_attr_get_type(attr);
> 

Hey Leon,

So the resource parsing functions correctly ignore the unkown attrs and
print everything else?

Looks good.

Reviewed-by: Steve Wise <swise@...ngridcomputing.com>