[<prev] [next>] [day] [month] [year] [list]
Date: Wed, 4 Apr 2018 11:11:46 -0600
From: David Ahern <dsahern@...il.com>
To: Miguel Fadon Perlines <mfadon@...dat.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] arp: fix arp_filter on l3slave devices
On 4/4/18 4:13 AM, Miguel Fadon Perlines wrote:
> arp_filter performs an ip_route_output search for arp source address and
>
> checks if output device is the same where the arp request was received,
>
> if it is not, the arp request is not answered.
>
>
>
> This route lookup is always done on main route table so l3slave devices
>
> never find the proper route and arp is not answered.
>
>
>
> Passing l3mdev_master_ifindex_rcu(dev) return value as oif fixes the
>
> lookup for l3slave devices while maintaining same behavior for non
>
> l3slave devices as this function returns 0 in that case.
>
>
>
> Signed-off-by: Miguel Fadon Perlines <mfadon@...dat.com>
>
> ---
Miguel: The change looks fine to me. Your mail showed up as html; it
needs to be sent as plain text only.
Powered by blists - more mailing lists