netdev - Re: [PATCH 06/12] wireless: Convert simple uses of a static const Ethernet broadcast address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 05 Apr 2018 15:48:17 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Christian Lamparter <chunkeey@...glemail.com>,
        Amitkumar Karwar <amitkarwar@...il.com>,
        Nishant Sarmukadam <nishants@...vell.com>,
        Ganapathi Bhat <gbhat@...vell.com>,
        Xinming Hu <huxm@...vell.com>,
        Ping-Ke Shih <pkshih@...ltek.com>,
        Jussi Kivilinna <jussi.kivilinna@....fi>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, b43-dev@...ts.infradead.org
Subject: Re: [PATCH 06/12] wireless: Convert simple uses of a static const Ethernet broadcast address

Kalle Valo <kvalo@...eaurora.org> writes:

> Joe Perches <joe@...ches.com> writes:
>
>> Use the new ether_broadcast_addr global instead to save some object code.
>>
>> Signed-off-by: Joe Perches <joe@...ches.com>
>> ---
>>  drivers/net/wireless/admtek/adm8211.c           | 3 +--
>>  drivers/net/wireless/ath/carl9170/mac.c         | 4 +---
>>  drivers/net/wireless/broadcom/b43/main.c        | 3 +--
>>  drivers/net/wireless/marvell/mwifiex/cfg80211.c | 3 +--
>>  drivers/net/wireless/realtek/rtlwifi/core.c     | 5 ++---
>>  drivers/net/wireless/rndis_wlan.c               | 6 +-----
>>  drivers/net/wireless/ti/wl1251/main.c           | 5 +----
>>  drivers/net/wireless/ti/wlcore/main.c           | 5 +----
>>  8 files changed, 9 insertions(+), 25 deletions(-)
>
> It would be really helpful if you could CLEARLY document in the patches
> (or in the cover letter but then you need to cc all parties) to what
> tree the patches are meant for. Otherwise I, and other maintainers as
> well, need to waste time trying to guess what's your plan.

Forgot to mention that for me the best approach is to have the tree name
in subject, just like Dave and Linus both recommend:

[PATCH 06/12 wireless-drivers-next] wireless: Convert simple uses of a static const Ethernet broadcast address

This way I can immeaditely see from patchwork to which tree the patch
should go which helps tremendously. And if the tree name is too long you
can always shorten it to w-d and w-d-next.

-- 
Kalle Valo