netdev - Re: [PATCH net 2/3] lan78xx: Add support to dump lan78xx registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180406144033.GM17495@lunn.ch>
Date:   Fri, 6 Apr 2018 16:40:33 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Raghuram Chary J <raghuramchary.jallipalli@...rochip.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        unglinuxdriver@...rochip.com, woojung.huh@...rochip.com
Subject: Re: [PATCH net 2/3] lan78xx: Add support to dump lan78xx registers

> +static int lan78xx_get_regs_len(struct net_device *netdev)
> +{
> +	return (sizeof(lan78xx_regs) + PHY_REG_SIZE);

If there is no PHY attached, you probably should not include
PHY_REG_SIZE here.

     Andrew