netdev - Re: [PATCH v5] net: thunderx: rework mac addresses list to u64 array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180409.110016.166919257730352493.davem@davemloft.net>
Date:   Mon, 09 Apr 2018 11:00:16 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     Vadim.Lomovtsev@...iumnetworks.com
Cc:     sgoutham@...ium.com, sunil.kovvuri@...il.com, rric@...nel.org,
        linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, dnelson@...hat.com,
        robin.murphy@....com, hch@...radead.org, gustavo@...eddedor.com,
        Vadim.Lomovtsev@...ium.com
Subject: Re: [PATCH v5] net: thunderx: rework mac addresses list to u64
 array

From: Vadim Lomovtsev <Vadim.Lomovtsev@...iumnetworks.com>
Date: Mon,  9 Apr 2018 06:24:48 -0700

> From: Vadim Lomovtsev <Vadim.Lomovtsev@...ium.com>
> 
> It is too expensive to pass u64 values via linked list, instead
> allocate array for them by overall number of mac addresses from netdev.
> 
> This eventually removes multiple kmalloc() calls, aviod memory
> fragmentation and allow to put single null check on kmalloc
> return value in order to prevent a potential null pointer dereference.
> 
> Addresses-Coverity-ID: 1467429 ("Dereference null return value")
> Fixes: 37c3347eb247 ("net: thunderx: add ndo_set_rx_mode callback implementation for VF")
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Vadim Lomovtsev <Vadim.Lomovtsev@...ium.com>

Applied, thanks.