netdev - Re: [PATCH net] ip_gre: clear feature flags when incompatible o

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALDO+Sa4YdQWPUuVpkC4yMyxAiKAt7PX4vcBxDSMuXUNsv80tw@mail.gmail.com>
Date:   Tue, 10 Apr 2018 06:36:14 -0700
From:   William Tu <u9012063@...il.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     Sabrina Dubroca <sd@...asysnail.net>,
        network dev <netdev@...r.kernel.org>,
        Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
Subject: Re: [PATCH net] ip_gre: clear feature flags when incompatible o_flags
 are set

On Tue, Apr 10, 2018 at 6:10 AM, Xin Long <lucien.xin@...il.com> wrote:
> On Tue, Apr 10, 2018 at 6:57 PM, Sabrina Dubroca <sd@...asysnail.net> wrote:
>> Commit dd9d598c6657 ("ip_gre: add the support for i/o_flags update via
>> netlink") added the ability to change o_flags, but missed that the
>> GSO/LLTX features are disabled by default, and only enabled some gre
>> features are unused. Thus we also need to disable the GSO/LLTX features
>> on the device when the TUNNEL_SEQ or TUNNEL_CSUM flags are set.
>>
>> These two examples should result in the same features being set:
>>
>>     ip link add gre_none type gre local 192.168.0.10 remote 192.168.0.20 ttl 255 key 0
>>
>>     ip link set gre_none type gre seq
>>     ip link add gre_seq type gre local 192.168.0.10 remote 192.168.0.20 ttl 255 key 1 seq
>>
>> Fixes: dd9d598c6657 ("ip_gre: add the support for i/o_flags update via netlink")
>> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>
>> ---

Looks good to me.
Acked-by: William Tu <u9012063@...il.com>


>>  net/ipv4/ip_gre.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
>> index a8772a978224..9c169bb2444d 100644
>> --- a/net/ipv4/ip_gre.c
>> +++ b/net/ipv4/ip_gre.c
>> @@ -781,8 +781,14 @@ static void ipgre_link_update(struct net_device *dev, bool set_mtu)
>>                     tunnel->encap.type == TUNNEL_ENCAP_NONE) {
>>                         dev->features |= NETIF_F_GSO_SOFTWARE;
>>                         dev->hw_features |= NETIF_F_GSO_SOFTWARE;
>> +               } else {
>> +                       dev->features &= ~NETIF_F_GSO_SOFTWARE;
>> +                       dev->hw_features &= ~NETIF_F_GSO_SOFTWARE;
>>                 }
>>                 dev->features |= NETIF_F_LLTX;
>> +       } else {
>> +               dev->hw_features &= ~NETIF_F_GSO_SOFTWARE;
>> +               dev->features &= ~(NETIF_F_LLTX | NETIF_F_GSO_SOFTWARE);
>>         }
>>  }
>>
>> --
>> 2.16.2
>>
> Reviewed-by: Xin Long <lucien.xin@...il.com>