netdev - Re: aquantia - BUG: unable to handle kernel NULL pointer dereference at 0000000000000058 on reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e60bad0c6e1edc71056b88843604543e283ace8.camel@declera.com>
Date:   Tue, 10 Apr 2018 17:06:56 +0300
From:   Yanko Kaneti <yaneti@...lera.com>
To:     Igor Russkikh <igor.russkikh@...antia.com>
Cc:     netdev <netdev@...r.kernel.org>
Subject: Re: aquantia - BUG: unable to handle kernel NULL pointer
 dereference at 0000000000000058 on reboot

On Tue, 2018-04-10 at 15:53 +0300, Igor Russkikh wrote:
> On 10.04.2018 15:42, Yanko Kaneti wrote:
> > Hello, 
> > 
> > Since 90869ddfefeb net: aquantia: Implement pci shutdown callback
> > I get the below oops on reboot.  Without the callback everything works
> > as expected.
> > 
> 
> Thanks, we also recently found out that.
> 
> Could you please try the below patch?

Works for me, as in, no crashes on reboot.

Thanks
-Yanko


> 
> 
> diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> index c96a921..32f6d2e 100644
> --- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> @@ -951,9 +951,11 @@ void aq_nic_shutdown(struct aq_nic_s *self)
>  
>  	netif_device_detach(self->ndev);
>  
> -	err = aq_nic_stop(self);
> -	if (err < 0)
> -		goto err_exit;
> +	if (netif_running(self->ndev)) {
> +		err = aq_nic_stop(self);
> +		if (err < 0)
> +			goto err_exit;
> +	}
>  	aq_nic_deinit(self);
>  
>  err_exit: