netdev - Re: [PATCH v2 net] slip: Check if rstate is initialized before uncompressing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180411.103411.2212608868988995529.davem@davemloft.net>
Date:   Wed, 11 Apr 2018 10:34:11 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     tejaswit@...eaurora.org
Cc:     netdev@...r.kernel.org, g.nault@...halink.fr
Subject: Re: [PATCH v2 net] slip: Check if rstate is initialized before
 uncompressing

From: Tejaswi Tanikella <tejaswit@...eaurora.org>
Date: Wed, 11 Apr 2018 16:34:47 +0530

> On receiving a packet the state index points to the rstate which must be
> used to fill up IP and TCP headers. But if the state index points to a
> rstate which is unitialized, i.e. filled with zeros, it gets stuck in an
> infinite loop inside ip_fast_csum trying to compute the ip checsum of a
> header with zero length.
 ...
> Adding a variable to indicate if the current rstate is initialized. If
> such a packet arrives, move to toss state.
> 
> Signed-off-by: Tejaswi Tanikella <tejaswit@...eaurora.org>

Applied and queued up for -stable, thanks.