netdev - Re: [PATCH] lan78xx: Don't reset the interface on open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180411.144545.61566209668287626.davem@davemloft.net>
Date:   Wed, 11 Apr 2018 14:45:45 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     phil@...pberrypi.org
Cc:     woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com,
        agraf@...e.de, tbogendoerfer@...e.de, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lan78xx: Don't reset the interface on open

From: Phil Elwell <phil@...pberrypi.org>
Date: Tue, 10 Apr 2018 13:18:25 +0100

> Commit 92571a1aae40 ("lan78xx: Connect phy early") moves the PHY
> initialisation into lan78xx_probe, but lan78xx_open subsequently calls
> lan78xx_reset. As well as forcing a second round of link negotiation,
> this reset frequently prevents the phy interrupt from being generated
> (even though the link is up), rendering the interface unusable.
> 
> Fix this issue by removing the lan78xx_reset call from lan78xx_open.
> 
> Fixes: 92571a1aae40 ("lan78xx: Connect phy early")
> Signed-off-by: Phil Elwell <phil@...pberrypi.org>

Applied and queued up for -stable, thanks.