netdev - Re: [PATCH net] virtio-net: add missing virtqueue kick when flushing packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180413.112712.74483562688980325.davem@davemloft.net>
Date:   Fri, 13 Apr 2018 11:27:12 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     jasowang@...hat.com
Cc:     mst@...hat.com, virtualization@...ts.linux-foundation.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        ktaka@....ac.jp, daniel@...earbox.net
Subject: Re: [PATCH net] virtio-net: add missing virtqueue kick when
 flushing packets

From: Jason Wang <jasowang@...hat.com>
Date: Fri, 13 Apr 2018 14:58:25 +0800

> We tends to batch submitting packets during XDP_TX. This requires to
> kick virtqueue after a batch, we tried to do it through
> xdp_do_flush_map() which only makes sense for devmap not XDP_TX. So
> explicitly kick the virtqueue in this case.
> 
> Reported-by: Kimitoshi Takahashi <ktaka@....ac.jp>
> Tested-by: Kimitoshi Takahashi <ktaka@....ac.jp>
> Cc: Daniel Borkmann <daniel@...earbox.net>
> Fixes: 186b3c998c50 ("virtio-net: support XDP_REDIRECT")
> Signed-off-by: Jason Wang <jasowang@...hat.com>

Applied and queued up for -stable, thanks Jason.