netdev - Re: [PATCH 2/2] net: socionext: reset hardware in ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180416.134704.356952030127566216.davem@davemloft.net>
Date:   Mon, 16 Apr 2018 13:47:04 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     jassisinghbrar@...il.com
Cc:     netdev@...r.kernel.org, masahisa.kojima@...aro.org,
        ard.biesheuvel@...aro.org, jaswinder.singh@...aro.org
Subject: Re: [PATCH 2/2] net: socionext: reset hardware in ndo_stop

From: jassisinghbrar@...il.com
Date: Mon, 16 Apr 2018 13:09:59 +0530

> From: Masahisa KOJIMA <masahisa.kojima@...aro.org>
> 
> When the interface is down, head/tail of the descriptor
> ring address is set to 0 in netsec_netdev_stop().
> But netsec hardware still keeps the previous descriptor
> ring address, so there is inconsistency between driver
> and hardware after interface is up at a later time.
> To address this inconsistency, add netsec_reset_hardware()
> when the interface is down.
> 
> In addition, to minimize the reset process,
> add flag to decide whether driver loads the netsec microcode.
> Even if driver resets the netsec hardware, netsec microcode
> keeps resident on RAM, so it is ok we only load the microcode
> at initialization.
> 
> This patch is critical for installation over network.
> 
> Signed-off-by: Masahisa KOJIMA <masahisa.kojima@...aro.org>
> Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
> Signed-off-by: Jassi Brar <jaswinder.singh@...aro.org>

Applied.