netdev - Re:Re: [PATCH net] net: Fix one possible memleak in ip_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4bba71b.4a6a.162cc69c1d6.Coremail.gfree.wind@vip.163.com>
Date:   Mon, 16 Apr 2018 11:05:05 +0800 (CST)
From:   "Gao Feng" <gfree.wind@....163.com>
To:     "davem@...emloft.net" <davem@...emloft.net>
Cc:     kuznet@....inr.ac.ru,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re:Re: [PATCH net] net: Fix one possible memleak in ip_setup_cork

At 2018-04-16 10:55:56, "David Miller" <davem@...emloft.net> wrote:
>From: gfree.wind@....163.com
>Date: Mon, 16 Apr 2018 10:16:45 +0800
>
>> From: Gao Feng <gfree.wind@....163.com>
>> 
>> It would allocate memory in this function when the cork->opt is NULL. But
>> the memory isn't freed if failed in the latter rt check, and return error
>> directly. It causes the memleak if its caller is ip_make_skb which also
>> doesn't free the cork->opt when meet a error.
>> 
>> Now move the rt check ahead to avoid the memleak.
>> 
>> Signed-off-by: Gao Feng <gfree.wind@....163.com>
>
>Why did you post this patch twice?

Sorry, it is my input error. I typed "yes" not "all" at the first time when execute git-send-email.
Then I corrected it as the second time.

Best Regards
Feng