netdev - Re: [PATCH net-next 07/21] net/ipv6: Save route type in rt6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2ff3c7e-a113-9eab-e25f-cf432b9e241b@gmail.com>
Date:   Mon, 16 Apr 2018 13:50:07 -0600
From:   David Ahern <dsahern@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, idosch@...sch.org,
        roopa@...ulusnetworks.com, eric.dumazet@...il.com,
        weiwan@...gle.com, kafai@...com, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH net-next 07/21] net/ipv6: Save route type in rt6_info

On 4/16/18 1:20 PM, David Miller wrote:
> From: David Ahern <dsahern@...il.com>
> Date: Mon, 16 Apr 2018 08:22:41 -0700
> 
>> @@ -2394,6 +2395,7 @@ static void addrconf_add_mroute(struct net_device *dev)
>>  		.fc_ifindex = dev->ifindex,
>>  		.fc_dst_len = 8,
>>  		.fc_flags = RTF_UP,
>> +		.fc_type = RTN_UNICAST,
>>  		.fc_nlinfo.nl_net = dev_net(dev),
>>  	};
>>  
> 
> Multicast route is of type RTN_UNICAST?
> 
> All of these cases where passing in a zero initialized value of
> fc_type up until this patch.  Perhaps you should discuss that in your
> commit message a little bit.

Added this to the commit message:

fc_type is set in current users based on the algorithm in rt6_fill_node:
  - rt6i_flags contains RTF_LOCAL: fc_type = RTN_LOCAL
  - rt6i_flags contains RTF_ANYCAST: fc_type = RTN_ANYCAST
  - else fc_type = RTN_UNICAST

Similarly, fib6_type is set in the rt6_info templates based on the
RTF_REJECT section of rt6_fill_node converting dst.error to RTN type.

#####

Will send a v2 later this week.