netdev - Re: [PATCH net-next 0/5] net: stmmac: Stop using hard-coded callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180416.185039.2065493119146889779.davem@davemloft.net>
Date:   Mon, 16 Apr 2018 18:50:39 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     Jose.Abreu@...opsys.com
Cc:     netdev@...r.kernel.org, Joao.Pinto@...opsys.com,
        peppe.cavallaro@...com, alexandre.torgue@...com
Subject: Re: [PATCH net-next 0/5] net: stmmac: Stop using hard-coded
 callbacks

From: Jose Abreu <Jose.Abreu@...opsys.com>
Date: Mon, 16 Apr 2018 16:08:11 +0100

> This a starting point for a cleanup and re-organization of stmmac.
> 
> In this series we stop using hard-coded callbacks along the code and use
> instead helpers which are defined in a single place ("hwif.h").
> 
> This brings several advantages:
> 	1) Less typing :)
> 	2) Guaranteed function pointer check
> 	3) More flexibility
> 
> By 2) we stop using the repeated pattern of:
> 	if (priv->hw->mac->some_func)
> 		priv->hw->mac->some_func(...)
> 
> I didn't check but I expect the final .ko will be bigger with this series
> because *all* of function pointers are checked.
> 
> Anyway, I hope this can make the code more readable and more flexible now.
> 
> [resending as per David Miller request]

Series applied, thanks Jose.