netdev - Re: [PATCH net] tcp: clear tp->packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 16 Apr 2018 11:24:23 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     soheil.kdev@...il.com
Cc:     netdev@...r.kernel.org, ycheng@...gle.com, ncardwell@...gle.com,
        subashab@...eaurora.org, hvtaifwkbgefbaei@...il.com,
        soheil@...gle.com, edumazet@...gle.com
Subject: Re: [PATCH net] tcp: clear tp->packets_out when purging write queue

From: Soheil Hassas Yeganeh <soheil.kdev@...il.com>
Date: Sat, 14 Apr 2018 20:44:46 -0400

> From: Soheil Hassas Yeganeh <soheil@...gle.com>
> 
> Clear tp->packets_out when purging the write queue, otherwise
> tcp_rearm_rto() mistakenly assumes TCP write queue is not empty.
> This results in NULL pointer dereference.
> 
> Also, remove the redundant `tp->packets_out = 0` from
> tcp_disconnect(), since tcp_disconnect() calls
> tcp_write_queue_purge().
> 
> Fixes: a27fd7a8ed38 (tcp: purge write queue upon RST)
> Reported-by: Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
> Reported-by: Sami Farin <hvtaifwkbgefbaei@...il.com>
> Tested-by: Sami Farin <hvtaifwkbgefbaei@...il.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Soheil Hassas Yeganeh <soheil@...gle.com>
> Acked-by: Yuchung Cheng <ycheng@...gle.com>
> Acked-by: Neal Cardwell <ncardwell@...gle.com>

Applied and queued up for -stable, thanks.