netdev - Re: [iproute PATCH] iproute: Abort if nexthop cannot be parsed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180416170017.14b5c80f@xeon-e3>
Date:   Mon, 16 Apr 2018 17:00:17 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Jakub Sitnicki <jkbs@...hat.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [iproute PATCH] iproute: Abort if nexthop cannot be parsed

On Wed, 11 Apr 2018 11:43:11 +0200
Jakub Sitnicki <jkbs@...hat.com> wrote:

> Attempt to add a multipath route where a nexthop definition refers to a
> non-existent device causes 'ip' to crash and burn due to stack buffer
> overflow:
> 
>   # ip -6 route add fd00::1/64 nexthop dev fake1
>   Cannot find device "fake1"
>   Cannot find device "fake1"
>   Cannot find device "fake1"
>   ...
>   Segmentation fault (core dumped)
> 
> Don't ignore errors from the helper routine that parses the nexthop
> definition, and abort immediately if parsing fails.
> 
> Signed-off-by: Jakub Sitnicki <jkbs@...hat.com>

Makes sense. Applied